Skip to content

[19587] Use SO_EXCLUSIVEADDRUSE for Win32 unicast listening sockets#4056

Merged
MiguelCompany merged 4 commits intomasterfrom
bugfix/19587
Nov 30, 2023
Merged

[19587] Use SO_EXCLUSIVEADDRUSE for Win32 unicast listening sockets#4056
MiguelCompany merged 4 commits intomasterfrom
bugfix/19587

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Nov 27, 2023

Description

Fixes a bug in Windows where a participant without whitelist ends up listening on the same unicast ports as a participant with whitelist. This made the whitelist participant get the incoming traffic to that port, making the non-whitelist one deaf to it.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.13.0 milestone Nov 27, 2023
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@EduPonz EduPonz added the needs-review PR that is ready to be reviewed label Nov 28, 2023
@EduPonz
Copy link
Copy Markdown

EduPonz commented Nov 28, 2023

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 28, 2023

@EduPonz
Copy link
Copy Markdown

EduPonz commented Nov 28, 2023

@richiprosima please test this

@EduPonz EduPonz added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed labels Nov 29, 2023
@EduPonz
Copy link
Copy Markdown

EduPonz commented Nov 29, 2023

@richiprosima please test mac

@MiguelCompany MiguelCompany merged commit bb2702b into master Nov 30, 2023
@MiguelCompany MiguelCompany deleted the bugfix/19587 branch November 30, 2023 06:11
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
* Refs #19587. Added regression unit tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Added regression blackbox test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit bb2702b)
EduPonz pushed a commit that referenced this pull request Dec 1, 2023
* Refs #19587. Added regression unit tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Added regression blackbox test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit bb2702b)
EduPonz pushed a commit that referenced this pull request Dec 3, 2023
…#4072)

* Refs #19587. Added regression unit tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Added regression blackbox test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit bb2702b)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
elianalf pushed a commit that referenced this pull request Dec 4, 2023
* Refs #19587. Added regression unit tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Added regression blackbox test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit bb2702b)
cferreiragonz pushed a commit that referenced this pull request Dec 5, 2023
* Refs #19587. Added regression unit tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Added regression blackbox test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit bb2702b)
EduPonz pushed a commit that referenced this pull request Dec 7, 2023
…#4071)

* Refs #19587. Added regression unit tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Added regression blackbox test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit bb2702b)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Dec 7, 2023
…#4070)

* Refs #19587. Added regression unit tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Added regression blackbox test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19587. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit bb2702b)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants