[19638] Log error message upon receiver resource creation failure#3924
Merged
MiguelCompany merged 1 commit intomasterfrom Oct 17, 2023
Merged
[19638] Log error message upon receiver resource creation failure#3924MiguelCompany merged 1 commit intomasterfrom
MiguelCompany merged 1 commit intomasterfrom
Conversation
1 task
Contributor
|
Can't set status; build succeeded. |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
2afa7c5 to
7569ebb
Compare
Contributor
Author
|
@richiprosima please test this |
MiguelCompany
approved these changes
Oct 17, 2023
Member
|
@richiprosima Please test mac |
1 similar comment
Member
|
@richiprosima Please test mac |
Member
|
@Mergifyio backport 2.11.x 2.10.x 2.6.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 77a85dd)
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 77a85dd)
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 77a85dd)
10 tasks
MiguelCompany
added a commit
that referenced
this pull request
Oct 26, 2023
* Log error message upon receiver resource creation failure (#3924) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 77a85dd) * Update src/cpp/rtps/participant/RTPSParticipantImpl.cpp * Rework log upon receiver resource creation failure (#3954) * Refs #19773. Turn log error into a log warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19773. Add boolean argument to `createReceiverResources`. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Oct 26, 2023
* Log error message upon receiver resource creation failure (#3924) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 77a85dd) * Rework log upon receiver resource creation failure (#3954) * Refs #19773. Turn log error into a log warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19773. Add boolean argument to `createReceiverResources`. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
LOG_ERRORmessage to indicate that it was not possible to build a receiver resource. This can be useful in case of using SHM transport and being unable to open or regenerate a port file even after trying with all mutation tries.Note: It can be argued if we should print the particular locator in the error message. I left it as it is in order not to expose more information than adequate
@Mergifyio backport 2.11.x 2.10.x 2.6.x
Fixes #3535, #3536
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist