Skip to content

[19266] Added atomic time_point initialization#3760

Merged
MiguelCompany merged 1 commit intomasterfrom
hotfix/timedeventimpl_atomic_init
Jul 28, 2023
Merged

[19266] Added atomic time_point initialization#3760
MiguelCompany merged 1 commit intomasterfrom
hotfix/timedeventimpl_atomic_init

Conversation

@jsan-rt
Copy link
Copy Markdown
Contributor

@jsan-rt jsan-rt commented Jul 27, 2023 •
edited by MiguelCompany
Loading

Adds explicit initialization of the atomic time_point added in #3745.

Description

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [NA] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [NA] Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [NA] New feature has been added to the versions.md file (if applicable).
  • [NA] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jsan-rt
Refs #19266: Added atomic time_point initialization
e6deb20 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt added this to the v2.11.2 milestone Jul 27, 2023
@MiguelCompany MiguelCompany modified the milestones: v2.11.2, v2.12.0 Jul 27, 2023
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Jul 27, 2023
@jsan-rt
Copy link
Copy Markdown
Contributor Author

jsan-rt commented Jul 28, 2023

@richiprosima please test mac

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 28, 2023
@MiguelCompany MiguelCompany merged commit 6e74c1e into master Jul 28, 2023
@MiguelCompany MiguelCompany deleted the hotfix/timedeventimpl_atomic_init branch July 28, 2023 09:55
jsan-rt added a commit that referenced this pull request Jul 28, 2023
@jsan-rt
Added atomic time_point initialization (#3760)
6f9aa71 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
jsan-rt added a commit that referenced this pull request Jul 28, 2023
@jsan-rt
Added atomic time_point initialization (#3760)
c6c33d0 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
jsan-rt added a commit that referenced this pull request Jul 28, 2023
@jsan-rt
Added atomic time_point initialization (#3760)
b5c16c3 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Aug 1, 2023
@mergify @cvilas @jsan-rt
Remove mutex from TimedEventImpl (#3751)
1e49fb9 
* [19256] Remove mutex from TimedEventImpl (#3745)

* Removes mutex from TimedEventImpl

Signed-off-by: Vilas Chitrakaran <cvilas@gmail.com>

* Please linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Vilas Chitrakaran <cvilas@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Holger Schulz <holger.schulz@durham.ac.uk>
(cherry picked from commit a7697c7)

* Added atomic time_point initialization (#3760)

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Vilas Kumar Chitrakaran <cvilas@gmail.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Aug 7, 2023
@mergify @cvilas @jsan-rt
Remove mutex from TimedEventImpl (#3745) (#3749)
637558b 
* [19256] Remove mutex from TimedEventImpl (#3745)

* Removes mutex from TimedEventImpl

Signed-off-by: Vilas Chitrakaran <cvilas@gmail.com>

* Please linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Vilas Chitrakaran <cvilas@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Holger Schulz <holger.schulz@durham.ac.uk>
(cherry picked from commit a7697c7)

* Added atomic time_point initialization (#3760)

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Vilas Kumar Chitrakaran <cvilas@gmail.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Aug 10, 2023
@mergify @cvilas @jsan-rt
Remove mutex from TimedEventImpl (#3745) (#3750)
46a96ff 
* [19256] Remove mutex from TimedEventImpl (#3745)

* Removes mutex from TimedEventImpl

Signed-off-by: Vilas Chitrakaran <cvilas@gmail.com>

* Please linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Vilas Chitrakaran <cvilas@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Holger Schulz <holger.schulz@durham.ac.uk>
(cherry picked from commit a7697c7)

* Added atomic time_point initialization (#3760)

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Vilas Kumar Chitrakaran <cvilas@gmail.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v2.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jsan-rt @MiguelCompany