Skip to content

[19247] Improve performance on intraprocess + data-sharing#3743

Merged
MiguelCompany merged 4 commits intomasterfrom
bugfix/datasharing-with-intraprocess
Jul 27, 2023
Merged

[19247] Improve performance on intraprocess + data-sharing#3743
MiguelCompany merged 4 commits intomasterfrom
bugfix/datasharing-with-intraprocess

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jul 24, 2023 •
edited
Loading

Description

This PR enables datasharing processing on readers which are directly notified by a datasharing writer in the same process.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
    • Some of the existing datasharing blackbox tests have been updated to run both with intraprocess on and off, so we can check for TSan report on possible deadlocks.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #19247. Some datasharing blackbox tests using intraprocess.
68b87c6 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #19247. Enable datasharing reception on intraprocess.
ddb1dfe 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #19247. Avoid acknacks on intraprocess.
c00a3de 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.12.0 milestone Jul 24, 2023
jsan-rt
jsan-rt reviewed Jul 25, 2023
View reviewed changes
@MiguelCompany
Refs #19247. Small refactor on send_ack_if_datasharing.
77caf2a 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
jsan-rt
jsan-rt approved these changes Jul 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@jsan-rt
Copy link
Copy Markdown
Contributor

jsan-rt commented Jul 25, 2023

@richiprosima please test this

@jsan-rt jsan-rt added ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 25, 2023
@MiguelCompany MiguelCompany merged commit c3b4de3 into master Jul 27, 2023
@MiguelCompany MiguelCompany deleted the bugfix/datasharing-with-intraprocess branch July 27, 2023 12:49
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Jul 27, 2023

@Mergifyio backport 2.11.x 2.10.x 2.6.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 27, 2023 •
edited
Loading

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jul 27, 2023
@MiguelCompany @mergify
Improve performance on intraprocess + data-sharing (#3743)
212f4cc 
* Refs #19247. Some datasharing blackbox tests using intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Enable datasharing reception on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Avoid acknacks on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Small refactor on send_ack_if_datasharing.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit c3b4de3)
mergify bot pushed a commit that referenced this pull request Jul 27, 2023
@MiguelCompany @mergify
Improve performance on intraprocess + data-sharing (#3743)
700348a 
* Refs #19247. Some datasharing blackbox tests using intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Enable datasharing reception on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Avoid acknacks on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Small refactor on send_ack_if_datasharing.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit c3b4de3)
This was referenced Jul 27, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jul 27, 2023
@MiguelCompany @mergify
Improve performance on intraprocess + data-sharing (#3743)
0dca7c5 
* Refs #19247. Some datasharing blackbox tests using intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Enable datasharing reception on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Avoid acknacks on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Small refactor on send_ack_if_datasharing.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit c3b4de3)
@mergify mergify bot mentioned this pull request Jul 27, 2023
Merged
MiguelCompany added a commit that referenced this pull request Aug 7, 2023
@mergify @MiguelCompany
Improve performance on intraprocess + data-sharing (#3743) (#3756)
bcc0b67 
* Refs #19247. Some datasharing blackbox tests using intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Enable datasharing reception on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Avoid acknacks on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Small refactor on send_ack_if_datasharing.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit c3b4de3)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Aug 8, 2023
@mergify @MiguelCompany
Improve performance on intraprocess + data-sharing (#3743) (#3757)
77654e9 
* Refs #19247. Some datasharing blackbox tests using intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Enable datasharing reception on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Avoid acknacks on intraprocess.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19247. Small refactor on send_ack_if_datasharing.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit c3b4de3)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jsan-rt jsan-rt jsan-rt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v2.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @jsan-rt