Skip to content

[18674] Fixes on XML schema#3534

Merged
MiguelCompany merged 3 commits intomasterfrom
hotfix/qos_nitpick
May 25, 2023
Merged

[18674] Fixes on XML schema#3534
MiguelCompany merged 3 commits intomasterfrom
hotfix/qos_nitpick

Conversation

@JesusPoderoso
Copy link
Copy Markdown
Contributor

@JesusPoderoso JesusPoderoso commented May 24, 2023 •
edited by MiguelCompany
Loading

Description

Recent change in the endpoint QoS XML schema (#3492) was not considered while merging new XML schema supported tags (#3399).
This hotfix would include the new definition in both endpoint QoS XML schema.

It also removes ownership strength from DataReadeQoS

@Mergifyio backport 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: Fix QoS definition Fast-DDS-docs#495
  • Applicable backports have been included in the description.
    Backport 2.10.x

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso
Include recently added XML supported tags in the schema
ab10ee6 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Fix QoS for Data Reader
052d5c9 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Update testing XML
2aca7cd 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v2.11.0 milestone May 24, 2023
@JesusPoderoso JesusPoderoso self-assigned this May 24, 2023
@JesusPoderoso JesusPoderoso added ci-pending PR which CI is running needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels May 24, 2023
@MiguelCompany MiguelCompany mentioned this pull request May 25, 2023
Closed
10 tasks
@MiguelCompany MiguelCompany changed the title XML schema Ownership strength QoS removed from Reader [18674] Fixes on XML schema May 25, 2023
@MiguelCompany MiguelCompany merged commit 81cd998 into master May 25, 2023
@MiguelCompany MiguelCompany deleted the hotfix/qos_nitpick branch May 25, 2023 10:43
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented May 25, 2023

@Mergifyio backport 2.10.x

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 25, 2023 •
edited
Loading

backport 2.10.x

✅ Backports have been created

Details

@mergify mergify bot mentioned this pull request May 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request May 25, 2023
@JesusPoderoso @mergify
Fixes on XML schema (#3534)
9b37281 
* Include recently added XML supported tags in the schema

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Fix QoS for Data Reader

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Update testing XML

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 81cd998)
EduPonz pushed a commit that referenced this pull request May 31, 2023
@mergify @JesusPoderoso
Fixes on XML schema (#3534) (#3538)
9a01da1 
* Include recently added XML supported tags in the schema

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Fix QoS for Data Reader

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Update testing XML

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 81cd998)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels

needs-review PR that is ready to be reviewed

Projects

None yet

Milestone

v2.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JesusPoderoso @MiguelCompany