Skip to content

[17099] Fix chain of trust issues#3294

Merged
MiguelCompany merged 7 commits intomasterfrom
bugfix/17099
Feb 15, 2023
Merged

[17099] Fix chain of trust issues#3294
MiguelCompany merged 7 commits intomasterfrom
bugfix/17099

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Feb 13, 2023 •
edited by EduPonz
Loading

Description

This should fix #3239 using the proposed solution.
A regression test has been added following the misbehavior described.

@Mergifyio backport 2.9.x 2.8.x 2.6.x 2.1.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #17099. Added malicious permissions file.
8167f72 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17099. Added regression test.
235e829 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17099. Put common code on auxiliary method.
86dbee2 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17099. Fix issue.
c6cc232 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17099. Uncrustify and comment.
0414a90 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17099. Check input before allocating output.
21c80b8 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Feb 14, 2023

@richiprosima Please test this.

@MiguelCompany MiguelCompany added this to the v2.10.0 milestone Feb 14, 2023
EduPonz
EduPonz suggested changes Feb 14, 2023
View reviewed changes
@MiguelCompany
Refs #17099. Improve error messages.
c72eb06 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany merged commit b6b178e into master Feb 15, 2023
@MiguelCompany MiguelCompany deleted the bugfix/17099 branch February 15, 2023 12:04
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Feb 15, 2023

https://github.com/Mergifyio backport 2.9.x 2.8.x 2.6.x 2.1.x

@mergify mergify bot mentioned this pull request Feb 15, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 15, 2023
@MiguelCompany @mergify
Fix chain of trust issues (#3294)
0c457b7 
* Refs #17099. Added malicious permissions file.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Added regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Put common code on auxiliary method.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Uncrustify and comment.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Check input before allocating output.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Improve error messages.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit b6b178e)
@mergify mergify bot mentioned this pull request Feb 15, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 15, 2023
@MiguelCompany @mergify
Fix chain of trust issues (#3294)
9a17c01 
* Refs #17099. Added malicious permissions file.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Added regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Put common code on auxiliary method.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Uncrustify and comment.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Check input before allocating output.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Improve error messages.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit b6b178e)
mergify bot pushed a commit that referenced this pull request Feb 15, 2023
@MiguelCompany @mergify
Fix chain of trust issues (#3294)
d72e01a 
* Refs #17099. Added malicious permissions file.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Added regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Put common code on auxiliary method.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Uncrustify and comment.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Check input before allocating output.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Improve error messages.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit b6b178e)
This was referenced Feb 15, 2023
Merged
Merged
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 15, 2023

backport 2.9.x 2.8.x 2.6.x 2.1.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Feb 15, 2023
@MiguelCompany @mergify
Fix chain of trust issues (#3294)
a3881f4 
* Refs #17099. Added malicious permissions file.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Added regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Put common code on auxiliary method.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Uncrustify and comment.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Check input before allocating output.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Improve error messages.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit b6b178e)
EduPonz pushed a commit that referenced this pull request May 12, 2023
@mergify @MiguelCompany
Fix chain of trust issues (#3294) (#3302)
61396ca 
* Refs #17099. Added malicious permissions file.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Added regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Put common code on auxiliary method.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Uncrustify and comment.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Check input before allocating output.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #17099. Improve error messages.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit b6b178e)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EduPonz EduPonz EduPonz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.10.0

Development

Successfully merging this pull request may close these issues.

[16903] Chain of trust issues with a single CA certificate

2 participants

@MiguelCompany @EduPonz