Skip to content

Support to run in parallel some tests [15290]#2886

Merged
EduPonz merged 18 commits intomasterfrom
feature/test-parallel
Jun 21, 2023
Merged

Support to run in parallel some tests [15290]#2886
EduPonz merged 18 commits intomasterfrom
feature/test-parallel

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Jul 27, 2022 •
edited by jsan-rt
Loading

Description

As title says.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Support to run in parallel some tests Support to run in parallel some tests [15290] Jul 27, 2022
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 1, 2022

@richiprosima Please test this

@richiware richiware force-pushed the feature/test-parallel branch 2 times, most recently from 332f4f6 to bf6ced1 Compare August 1, 2022 10:13
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 1, 2022

@richiprosima Please test this

1 similar comment
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 2, 2022

@richiprosima Please test this

jsan-rt
jsan-rt suggested changes Aug 4, 2022
View reviewed changes
@richiware richiware force-pushed the feature/test-parallel branch from 26e152f to d68b310 Compare August 4, 2022 12:25
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 5, 2022

@richiprosima Please test this

@jsan-rt
Copy link
Copy Markdown
Contributor

jsan-rt commented Aug 5, 2022

@richiprosima Please test this. I uploaded new configuration to actually test with parallel execution enabled.

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 5, 2022

@richiprosima Please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 8, 2022

@richiprosima Please test windows

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 9, 2022

@richiprosima Please test linux

3 similar comments
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 9, 2022

@richiprosima Please test linux

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 9, 2022

@richiprosima Please test linux

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 9, 2022

@richiprosima Please test linux

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 11, 2022

@richiprosima Please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 29, 2022

@richiprosima Please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Aug 29, 2022

@richiprosima Please test this

1 similar comment
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 14, 2022

@richiprosima Please test this

@richiware richiware force-pushed the feature/test-parallel branch from 2dfc50f to e49b709 Compare September 14, 2022 10:09
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 14, 2022

@richiprosima Please test this

@richiware richiware force-pushed the feature/test-parallel branch from e49b709 to b8a9877 Compare September 14, 2022 10:28
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 14, 2022

@richiprosima Please test this

@richiware richiware force-pushed the feature/test-parallel branch from b8a9877 to ebdf168 Compare October 3, 2022 11:33
@MiguelCompany MiguelCompany added this to the v2.9.0 milestone Nov 8, 2022
@richiware richiware force-pushed the feature/test-parallel branch from ebdf168 to d044e72 Compare November 15, 2022 11:32
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Nov 17, 2022

@richiprosima Please test this

1 similar comment
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Nov 18, 2022

@richiprosima Please test this

@EduPonz EduPonz added the to-do label Dec 9, 2022
richiware and others added 10 commits June 13, 2023 14:14
@richiware
Refs #15247. Fix windows linkage
0828dff 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #15247. Add clean-up mechanishm on communication tests
8a81615 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware
Refs #15247. Add clean-up mechanism before run all tests.
bc33dec 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware
Refs #15247. Fix accessing memory when creating short topic payloads
7172adb 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware
Refs #15247. Fix datarace in flowcontroller test
fcab7e4 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware
Refs #15247. Test using different domains
26d136c 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware
Refs #15247. AVoid creating all interprocess_semaphore at beginning
1ed1c93 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #15247.
c7608d6 
Refs #15247. Fix error in ParticipantTests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #15247. Fix error after rebase
bc9f7b9 
Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware
Refs #15247. Fix linkage error on Windows
b41893d 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the feature/test-parallel branch from b784959 to b41893d Compare June 13, 2023 12:19
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Jun 13, 2023

@richiprosima Please test this

@jsan-rt
Copy link
Copy Markdown
Contributor

jsan-rt commented Jun 16, 2023

@richiprosima please test this

1 similar comment
@jsan-rt
Copy link
Copy Markdown
Contributor

jsan-rt commented Jun 19, 2023

@richiprosima please test this

@jsan-rt
Copy link
Copy Markdown
Contributor

jsan-rt commented Jun 19, 2023

It looks like some tests are redefining symbols by adding the same file already included in Fast DDS library again, could you check it?

@richiware
Refs #15247. Fix sasnitizer errors after rebase
290e643 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@jsan-rt
Copy link
Copy Markdown
Contributor

jsan-rt commented Jun 19, 2023

@richiprosima please test this

@richiware
Refs #15247. Fix windows compilation errors
c6fb20a 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Jun 20, 2023

@richiprosima please test this

@Mario-DL Mario-DL added ci-pending PR which CI is running and removed to-do labels Jun 20, 2023
@jsan-rt
Copy link
Copy Markdown
Contributor

jsan-rt commented Jun 20, 2023

@richiprosima please test windows

@jsan-rt jsan-rt added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 21, 2023
@EduPonz EduPonz merged commit 9873d7a into master Jun 21, 2023
@EduPonz EduPonz deleted the feature/test-parallel branch June 21, 2023 07:28
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 23, 2023
Merged
9 tasks
@EduPonz EduPonz mentioned this pull request Jul 7, 2023
Merged
7 tasks
juanlofer-eprosima pushed a commit that referenced this pull request Nov 10, 2023
@richiware @juanlofer-eprosima
Support to run in parallel some tests (#2886)
a5053af 
* Refs #15247. Support to run in parallel some tests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix compilation error

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix compilation error after rebase

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix compilation error on Windows

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix uncrustify

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix windows linkage

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Add clean-up mechanishm on communication tests

Signed-off-by: Ricardo González <correoricky@gmail.com>

* Refs #15247. Add clean-up mechanism before run all tests.

Signed-off-by: Ricardo González <correoricky@gmail.com>

* Refs #15247. Fix accessing memory when creating short topic payloads

Signed-off-by: Ricardo González <correoricky@gmail.com>

* Refs #15247. Fix datarace in flowcontroller test

Signed-off-by: Ricardo González <correoricky@gmail.com>

* Refs #15247. Test using different domains

Signed-off-by: Ricardo González <correoricky@gmail.com>

* Refs #15247. AVoid creating all interprocess_semaphore at beginning

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247.
Refs #15247. Fix error in ParticipantTests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix error after rebase

Signed-off-by: Ricardo González <correoricky@gmail.com>

* Refs #15247. Fix linkage error on Windows

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix sasnitizer errors after rebase

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #15247. Fix windows compilation errors

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González <correoricky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jsan-rt jsan-rt jsan-rt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v2.11.0

Development

Successfully merging this pull request may close these issues.

6 participants

@richiware @jsan-rt @EduPonz @MiguelCompany @JLBuenoLopez @Mario-DL