Refs #3139. Added topic profile support.#256
Merged
Conversation
MiguelCompany
requested changes
Sep 11, 2018
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
New features should go to develop, please rebase on develop and request the pull on develop.
…present but not 'max' tag (#252)
b33f4c5 to
eaddc0d
Compare
Contributor
Author
|
Sorry, I fixed it. |
MiguelCompany
requested changes
Sep 11, 2018
| * @param id User defined ID to be set | ||
| */ | ||
| inline void setUserDefinedID(uint8_t id){m_userDefinedID = id; }; | ||
| inline void setUserDefinedID(uint8_t id) { m_userDefinedID = id; } |
Member
There was a problem hiding this comment.
Pleas remove also the TAB character
| { | ||
| subscriber_attributes = default_subscriber_attributes; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think we should also add a getDefaultTopicAttributes method
eaddc0d to
425f93d
Compare
MiguelCompany
approved these changes
Sep 12, 2018
richiware
approved these changes
Sep 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added topic profile support for XML.