Skip to content

Fix tests with Log: avoid use of references to string literals that may be removed after main function exit [16948]#3271

Closed
irenebm wants to merge 1 commit intomasterfrom
bug/logError_APIbreak
Closed

Fix tests with Log: avoid use of references to string literals that may be removed after main function exit [16948]#3271
irenebm wants to merge 1 commit intomasterfrom
bug/logError_APIbreak

Conversation

@irenebm
Copy link
Copy Markdown
Contributor

@irenebm irenebm commented Feb 6, 2023

Signed-off-by: Irene Bandera irenebandera@eprosima.com

Description

https://github.com/eProsima/Fast-DDS/tree/bug/logError

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@irenebm
Fix test
95b18be 
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm changed the title Fix tests with Log: avoid use of references to string literals that may be removed after main function exit. Fix tests with Log: avoid use of references to string literals that may be removed after main function exit [16948] Feb 7, 2023
@JLBuenoLopez JLBuenoLopez added this to the v2.11.0 milestone Mar 16, 2023
@EduPonz EduPonz modified the milestones: v2.11.0, v2.11.1 Jun 21, 2023
@MiguelCompany MiguelCompany modified the milestones: v2.11.1, v2.11.2 Jul 6, 2023
@JesusPoderoso JesusPoderoso modified the milestones: v2.11.2, v2.12.0 Jul 10, 2023
@EduPonz
Copy link
Copy Markdown

EduPonz commented Sep 18, 2023

As discussed internally, we already merged an ABI compatible fix for this issue. I'm closing this for now.

@EduPonz EduPonz closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@irenebm irenebm

Labels

to-do

Projects

None yet

Milestone

v2.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@irenebm @EduPonz @MiguelCompany @JLBuenoLopez @JesusPoderoso