Fix singleton destruction order <master> [10533]#1748
Merged
MiguelCompany merged 5 commits intomasterfrom Feb 11, 2021
Merged
Conversation
These singletons are used on the destruction of certain classes. In order to avoid these singletons to be already destructed, these classes keep a shared_pointer to an instance to the singleton. This ensures that the singleton is destructed AFTER the class instance. Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Member
|
Build status:
|
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
MiguelCompany
requested changes
Feb 9, 2021
src/cpp/rtps/history/TopicPayloadPoolRegistry_impl/TopicPayloadPoolRegistry.hpp
Outdated
Show resolved
Hide resolved
Member
|
Build status:
|
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
b9d6750 to
b8bd004
Compare
MiguelCompany
approved these changes
Feb 10, 2021
5 tasks
Contributor
|
Build status:
|
IkerLuengo
added a commit
that referenced
this pull request
Feb 12, 2021
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
IkerLuengo
added a commit
that referenced
this pull request
Feb 12, 2021
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
IkerLuengo
added a commit
that referenced
this pull request
Feb 12, 2021
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Feb 13, 2021
* Fix singleton destruction order (port of #1748) Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * uncrustify Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These singletons are used on the destruction of certain classes.
In order to avoid these singletons to be already destructed,
these classes keep a shared_pointer to an instance to the singleton.
This ensures that the singleton is destructed AFTER the class instance.