Skip to content

[21295] Participant discovery structures refactor#99

Merged
MiguelCompany merged 5 commits intomasterfrom
participant_discovery_data_refactor
Jul 24, 2024
Merged

[21295] Participant discovery structures refactor#99
MiguelCompany merged 5 commits intomasterfrom
participant_discovery_data_refactor

Conversation

@elianalf
Copy link
Copy Markdown
Contributor

@elianalf elianalf commented Jul 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR substitutes ParticipantDiscoveryInfo with ParticipantBuiltinTopicData according to the changes in Fast DDS PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • N/A Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v2.0.0 milestone Jul 16, 2024
@elianalf elianalf mentioned this pull request Jul 16, 2024
Merged
11 tasks
Base automatically changed from feature/21301 to master July 17, 2024 05:58
@MiguelCompany MiguelCompany force-pushed the participant_discovery_data_refactor branch from 8c19a64 to 074a6da Compare July 19, 2024 09:11
MiguelCompany
MiguelCompany approved these changes Jul 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elianalf elianalf force-pushed the participant_discovery_data_refactor branch from 074a6da to 3089984 Compare July 22, 2024 14:08
@elianalf elianalf changed the base branch from master to hotfix/build_example July 22, 2024 14:09
Base automatically changed from hotfix/build_example to master July 23, 2024 12:19
elianalf added 5 commits July 23, 2024 16:10
@elianalf
Compile examples
1f243ae 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Remove discovery-server.xsd
dfaf9ee 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
remove discovery server example
97316e1 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Apply suggestions
33c0417 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21295: Substitute ParticipantDiscoveryInfo with ParticipantBuil…
9439c8c 
…tinTopicData

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the participant_discovery_data_refactor branch from 3089984 to 9439c8c Compare July 23, 2024 14:12
@MiguelCompany MiguelCompany self-requested a review July 23, 2024 14:37
@MiguelCompany MiguelCompany merged commit 0dad773 into master Jul 24, 2024
@MiguelCompany MiguelCompany deleted the participant_discovery_data_refactor branch July 24, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@elianalf @MiguelCompany