Skip to content

[22056] Transform locators using new host_id PID#107

Merged
cferreiragonz merged 2 commits intomasterfrom
feature/pid_host_id_to_parameterTypes
Nov 18, 2024
Merged

[22056] Transform locators using new host_id PID#107
cferreiragonz merged 2 commits intomasterfrom
feature/pid_host_id_to_parameterTypes

Conversation

@cferreiragonz
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz commented Nov 6, 2024

Description

This PR includes a test for a bug in which a TCP client connecting to localhost is unable to identify the locator of a TCP discovery server with a custom GUID listening on any.
Depends on:

@Mergifyio backport 1.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending labels Nov 18, 2024
@cferreiragonz cferreiragonz merged commit 5777caa into master Nov 18, 2024
@cferreiragonz cferreiragonz deleted the feature/pid_host_id_to_parameterTypes branch November 18, 2024 09:43
@cferreiragonz
Copy link
Copy Markdown
Contributor Author

@Mergifyio backport 1.2.x

@mergify
Copy link
Copy Markdown

mergify bot commented Nov 18, 2024

backport 1.2.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Nov 18, 2024
* Refs #22056: Typo in comment

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22056: TCP-DS host_id test

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 5777caa)

# Conflicts:
#	test/CMakeLists.txt
#	test/configuration/test_cases/test_95_tcpv4_cli.xml
#	test/configuration/test_cases/test_96_tcpv6_cli.xml
#	test/configuration/test_cases/test_97_tcpv4_env_var.xml
#	test/configuration/test_cases/test_98_tcpv6_env_var.xml
cferreiragonz added a commit that referenced this pull request Nov 18, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz added a commit that referenced this pull request Dec 20, 2024
… TCP tests

* Bp #107: TCP tests

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Fix TCP tests in 1.2.x

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Co-authored-by: cferreiragonz <carlosferreira@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants