Skip to content

fix validators cast and improve docs#873

Merged
rochacbruno merged 1 commit intomasterfrom
fix_cast_validators
Mar 2, 2023
Merged

fix validators cast and improve docs#873
rochacbruno merged 1 commit intomasterfrom
fix_cast_validators

Conversation

@rochacbruno
Copy link
Copy Markdown
Member

@rochacbruno rochacbruno commented Mar 2, 2023

Fix: #823
Fix: #834

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 2, 2023

Deploy Preview for dynaconf ready!

Name Link
🔨 Latest commit 4afd38a
🔍 Latest deploy log https://app.netlify.com/sites/dynaconf/deploys/64009f5f4c88d0000888e064
😎 Deploy Preview https://deploy-preview-873--dynaconf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2023

Test Results (Python 3.10)

392 tests  +24   392 ✔️ +24   34s ⏱️ -1s
    1 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit 4afd38a. ± Comparison against base commit 61e59ca.

This pull request removes 1 and adds 25 tests. Note that renamed tests count towards both.
tests.test_validators ‑ test_cast_before_validate
tests.test_validators ‑ test_cast_on_validate_transforms_value
tests.test_validators ‑ test_ensure_cast_happens_after_must_exist
tests.test_validators ‑ test_ensure_cast_works_for_non_default_values
tests.test_validators_conditions ‑ test_conditions[data20]
tests.test_validators_conditions ‑ test_negative_conditions[data0]
tests.test_validators_conditions ‑ test_negative_conditions[data10]
tests.test_validators_conditions ‑ test_negative_conditions[data11]
tests.test_validators_conditions ‑ test_negative_conditions[data12]
tests.test_validators_conditions ‑ test_negative_conditions[data13]
tests.test_validators_conditions ‑ test_negative_conditions[data14]
…

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2023

Test Results (Python 3.8)

392 tests  +24   392 ✔️ +24   39s ⏱️ +8s
    1 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit 4afd38a. ± Comparison against base commit 61e59ca.

This pull request removes 1 and adds 25 tests. Note that renamed tests count towards both.
tests.test_validators ‑ test_cast_before_validate
tests.test_validators ‑ test_cast_on_validate_transforms_value
tests.test_validators ‑ test_ensure_cast_happens_after_must_exist
tests.test_validators ‑ test_ensure_cast_works_for_non_default_values
tests.test_validators_conditions ‑ test_conditions[data20]
tests.test_validators_conditions ‑ test_negative_conditions[data0]
tests.test_validators_conditions ‑ test_negative_conditions[data10]
tests.test_validators_conditions ‑ test_negative_conditions[data11]
tests.test_validators_conditions ‑ test_negative_conditions[data12]
tests.test_validators_conditions ‑ test_negative_conditions[data13]
tests.test_validators_conditions ‑ test_negative_conditions[data14]
…

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2023

Test Results (Python 3.11)

392 tests  +24   392 ✔️ +24   45s ⏱️ +10s
    1 suites ±  0       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit 4afd38a. ± Comparison against base commit 61e59ca.

This pull request removes 1 and adds 25 tests. Note that renamed tests count towards both.
tests.test_validators ‑ test_cast_before_validate
tests.test_validators ‑ test_cast_on_validate_transforms_value
tests.test_validators ‑ test_ensure_cast_happens_after_must_exist
tests.test_validators ‑ test_ensure_cast_works_for_non_default_values
tests.test_validators_conditions ‑ test_conditions[data20]
tests.test_validators_conditions ‑ test_negative_conditions[data0]
tests.test_validators_conditions ‑ test_negative_conditions[data10]
tests.test_validators_conditions ‑ test_negative_conditions[data11]
tests.test_validators_conditions ‑ test_negative_conditions[data12]
tests.test_validators_conditions ‑ test_negative_conditions[data13]
tests.test_validators_conditions ‑ test_negative_conditions[data14]
…

@rochacbruno rochacbruno merged commit 816a500 into master Mar 2, 2023
@rochacbruno rochacbruno added this to the 3.1.12 milestone Mar 2, 2023
rochacbruno added a commit that referenced this pull request Mar 2, 2023
Shortlog of commits since last release:

    André "decko" de Brito (2):
          Removes Codacy Coverage Reporter (#871)
          Add a namespace property for VAULT_FOR_DYNACONF dict (#870)

    Bruno Rocha (8):
          Release version 3.1.11
          bump dev version to 3.1.12
          Ensure `dynaconf get` returns a valid json string. (#813)
          [bugfix] Fix access of keys with spaces (#815)
          hotfix func tests (#816)
          Add Python 3.11 to CI (#830)
          fix lint error
          Fix casting on Validator and improve docs (#873)

    Bryan Weber (1):
          Fix typos in envvars docs (#840)

    Florian Apolloner (1):
          Small typo fix. (#822)

    Maxwell G (1):
          Include license files for vendored deps (#841)

    MicLon (1):
          fix: envvars.md get `HOME` environment variable (#831)

    Otávio Dantas (1):
          doc(pt-br): translate flask extension to pt-br (#852)

    Sergio Kef (1):
          Fix code snippet in docs (#843)

    Tetiana (1):
          #817 Add note about defining root_path when testing (#818)

    jctanner (1):
          Handle all failures when pwd does not exist. (#857)

    jmeichle (1):
          Add support for VAULT_NAMESPACE_FOR_DYNACONF (#854)
@rochacbruno rochacbruno deleted the fix_cast_validators branch March 3, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Validator only casts default value [bug] Validator cast happens before must_exist check

1 participant