Organize pre-commit setup#757
Merged
rochacbruno merged 3 commits intodynaconf:masterfrom Jun 6, 2022
johnnv1:organize/pre-commit
Merged
Organize pre-commit setup#757rochacbruno merged 3 commits intodynaconf:masterfrom johnnv1:organize/pre-commit
rochacbruno merged 3 commits intodynaconf:masterfrom
johnnv1:organize/pre-commit
Conversation
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1748 1748
=========================================
Hits 1748 1748 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, i take a look at pre-commit config and think some things can be updated to be more clean/organized
The changes:
setup-pre-commitbecause the pre-commit will install by default in the first run.--all-filesand keeps the ignore files for the pre-commit (maybe can be used justpre-commit runhere)pre-commit autoupdateMaybe for other PR the pyupgrade hook can be added to pre-commit to upgrade syntax for newer versions. That can also be used with
from __future__ import annotationsatreorder-python-importsto update the type annotations.