fix(deps)!: Remove runtime/frankenphp-symfony dependency#873
fix(deps)!: Remove runtime/frankenphp-symfony dependency#873dunglas merged 2 commits intodunglas:mainfrom
runtime/frankenphp-symfony dependency#873Conversation
…ng for new projects
104e2a8 to
94a9e65
Compare
|
CI / Lint failed due the #874. |
|
If we do this that way, it means that we can't use this repo easily with a version <7.4. Maybe we should introduce a condition :
|
|
Hi, @shulard! I agree with you, backward compatibility is important. Thanks for mentioning this. However, in this repository, backward compatibility is generally not implemented. I can rewrite this PR to support backward compatibility. @dunglas @maxhelias Is this necessary? Alternatively, instead of deleting lines, I can suggest commenting out it and adding the comment "Uncomment this lines for Symfony < 7.4". WDYT? Summary of the impact of the current proposed changes:
|
runtime/frankenphp-symfony dependencyruntime/frankenphp-symfony dependency
|
to me, its good to have this as sf 7.4 (lts) as minimum version 👍🏻 this project has a link from the official doc |
|
Thanks! |
The latest version of Symfony v7.4 introduces native runner support for FrankenPHP (see symfony/symfony#60503). The current new project initialization script explicitly adds the
runtime/frankenphp-symfonydependency, which is no longer needed for projects running the latest version of Symfony.For Symfony v8.0 (the default version), adding the
runtime/frankenphp-symfonypackage results in an error (see #872).Details
With this PR, I propose removing the addition of the
runtime/frankenphp-symfonydependency and explicitly indicating to Symfony which runtime should be used via theAPP_RUNTIMEenv.BREAKING CHANGE: Removing the
APP_RUNTIMEenv will break existing Symfony <7.4 projects when using worker mode.