Clarify arrow_lossless_conversion option#5541
Closed
NickCrews wants to merge 1 commit intoduckdb:mainfrom
Closed
Conversation
Collaborator
|
Thanks! This is auto-generated so I turned it into a PR to the main codebase. |
Collaborator
|
@NickCrews I PR'd this to the main codebase. We try to keep the codebase self-contained, so unfortunately I could not include the link to the discussion in the pull request. |
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by duckdb/duckdb#17857 (comment)
In particular, the existing phrasing of "When a duckdb typedoes not have a clear native or canonical extension match in Arrow" makes it sound like this option should not affect UUID types, since there is a canonical extension type for uuid in arrow. I think the new phrasing is more accurate of when this option has an effect.
It now doesn't mention the fact that we generate our own
Duckdb.*extension type, but I think that is fine. Before, it wasn't really enough info to actually be useful anyways. If we did want to mention this, I can adjust the PR.The result is significantly longer than the description for the other options, but I would rather have precision and it be fully explained rather than brevity.