SQLite scanner: use SQLite-like type affinity for determining types#18
Merged
Mytherin merged 8 commits intoduckdb:mainfrom Nov 12, 2022
Merged
SQLite scanner: use SQLite-like type affinity for determining types#18Mytherin merged 8 commits intoduckdb:mainfrom
Mytherin merged 8 commits intoduckdb:mainfrom
Conversation
This was referenced Nov 12, 2022
ak2k
pushed a commit
to ak2k/duckdb-sqlite
that referenced
this pull request
Jun 7, 2025
SQLite scanner: use SQLite-like type affinity for determining types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12 and #14
This PR reworks the SQLite scanner to use SQLite's column affinity rules, with some minor adaptations. The rules are as follows:
The rules are implemented as-is, however, the final catch-all type "numeric" turns out to be quite a strange type.
As such, we have some additional fallback options:
Finally, we give up and go back to VARCHAR.
As a result of this new type conversion we can also drop a few conversion loops (smallint, int and decimal) as they are never generated.