Fixup linking of libraries for Wasm#634
Merged
Maxxen merged 1 commit intoduckdb:v1.3.1from Jul 7, 2025
Merged
Conversation
It's unclear to me why the symbol pj_release do not get properly exported, and I don't have a fix in PROJ, but this solves the problem (basically by re-linking the libraries again
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Jul 7, 2025
… Wasm (#18170) On top of #18161 (now merged), small bump further to handle limitation of linking in duckb-wasm solved via (duckdb/duckdb-spatial#634)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unclear to me why the symbol
pj_releasedo not get properly exported to the final binary in Wasm, and I don't have a fix in PROJ, but this solves the problem (basically by re-linking the libraries again).This is behind an
EMSCRIPTENifdef, so should be sort of safe.