Only add Content-Type if not already present in the headers#89
Merged
samansmink merged 1 commit intoduckdb:mainfrom Jul 23, 2025
Merged
Conversation
samansmink
approved these changes
Jul 22, 2025
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Jul 24, 2025
Includes commit to not add an extra header to post requests duckdb/duckdb-httpfs#89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we can add to headers of "Content-Type". Some servers may prefer the last seen value, and if it doesn't match the content type for the url, the server may return an error.
This is happening currently with the cloudflare R2 iceberg catalog. The Iceberg client adds the header
Content-Type: application/jsonthen httpfs addsContent-Type: application/octet-streamand Cloudflare responds with"Expected request with
Content-Type: application/json"