feat(python): throw HTTPExceptions instead of IOException for http errors#6533
Merged
Mytherin merged 26 commits intoduckdb:masterfrom Mar 7, 2023
Merged
feat(python): throw HTTPExceptions instead of IOException for http errors#6533Mytherin merged 26 commits intoduckdb:masterfrom
Mytherin merged 26 commits intoduckdb:masterfrom
Conversation
Tishj
reviewed
Mar 3, 2023
Contributor
Tishj
left a comment
There was a problem hiding this comment.
Looks like a great change, saving the response + error code is definitely a good idea!
| # We only run this test if this env var is set | ||
| pytestmark = mark.skipif( | ||
| not os.getenv('DUCKDB_PYTHON_TEST_EXTENSION_REQUIRED', False), | ||
| reason='httpfs extension not available' |
Contributor
There was a problem hiding this comment.
Isn't this already done by require ?
I recently learned you can actually see these reasons when you run pytest with the -rs flags. (hardly documented anywhere for some reason)
Contributor
Author
There was a problem hiding this comment.
Yeah I'm not sure why this environment variable exists, happy to remove this check though
no longer required in fsspec 2023.3.0
Collaborator
|
Thanks! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've pulled out the NodeJS equivalent, will submit it once #6434 is merged
Feedback on C++ code very welcome!