feat(nodejs): add errorType attribute to DuckDbError#6434
Merged
Mytherin merged 3 commits intoduckdb:masterfrom Mar 7, 2023
Merged
feat(nodejs): add errorType attribute to DuckDbError#6434Mytherin merged 3 commits intoduckdb:masterfrom
Mytherin merged 3 commits intoduckdb:masterfrom
Conversation
Contributor
Author
|
For some reason the NodeJS job seems to be intermittently failing with connection issues, not sure why |
Collaborator
|
It looks like this PR has come with a lot of other changes - could you perhaps rebase to feature? |
dfdbf69 to
923bba4
Compare
Contributor
Author
Oops, fixed |
Winterhart
reviewed
Mar 2, 2023
Winterhart
left a comment
There was a problem hiding this comment.
Hi 👋🏼
Feel free to discard this comment as I don't have the full context about this PR and project
I just wanted to provide another approach to the extending Error idea.
Cheers,
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pre work for the http exception feature I'm looking to add for the next release