Merged
Conversation
Mytherin
reviewed
Oct 25, 2022
src/common/file_buffer.cpp
Outdated
| // | ||
| // make room for the block header (if this is not the db file header) | ||
| // | ||
| // qq: Why is the second condition (new_size != Storage::FILE_HEADER_SIZE) necessary? |
Collaborator
There was a problem hiding this comment.
This is likely a special case for the file header (the first 4KB of the file) - we could likely work around it elsewhere if the special case is removed as well.
Collaborator
|
Thanks! |
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
Jun 5, 2025
* Just do signed compares to see if this fixes the Win32 test failure
Mytherin
added a commit
that referenced
this pull request
Jun 6, 2025
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 6, 2025
Internal duckdb/duckdb#5069: Win32 Cast Simplification (duckdb/duckdb#17820)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 6, 2025
Internal duckdb/duckdb#5069: Win32 Cast Simplification (duckdb/duckdb#17820) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables a storage engine to vary the block size.
Along the way: