[chore] Fixup autocomplete missing std::move#20773
Merged
Mytherin merged 1 commit intoduckdb:v1.5-variegatafrom Feb 2, 2026
Merged
[chore] Fixup autocomplete missing std::move#20773Mytherin merged 1 commit intoduckdb:v1.5-variegatafrom
Mytherin merged 1 commit intoduckdb:v1.5-variegatafrom
Conversation
Contributor
|
Apologies for the inconvenience and I agree, we should catch this earlier. Change looks good to me :) |
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-02-02 15:48:03 +0100 [WAL] wal_autocheckpoint_entries setting (duckdb/duckdb#20720) add index iterate patch to spatial (duckdb/duckdb#20775) [chore] Fixup autocomplete missing std::move (duckdb/duckdb#20773)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-02-02 15:48:03 +0100 [WAL] wal_autocheckpoint_entries setting (duckdb/duckdb#20720) add index iterate patch to spatial (duckdb/duckdb#20775) [chore] Fixup autocomplete missing std::move (duckdb/duckdb#20773)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-02-02 15:48:03 +0100 [WAL] wal_autocheckpoint_entries setting (duckdb/duckdb#20720) add index iterate patch to spatial (duckdb/duckdb#20775) [chore] Fixup autocomplete missing std::move (duckdb/duckdb#20773)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-02-02 15:48:03 +0100 [WAL] wal_autocheckpoint_entries setting (duckdb/duckdb#20720) add index iterate patch to spatial (duckdb/duckdb#20775) [chore] Fixup autocomplete missing std::move (duckdb/duckdb#20773)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be handy to consider either Bundle (at leat on Linux) by default on CI, or some equivalent CI run to catch those earlier.