Skip to content

Add back spatial to V1.5, patch ducklake#20734

Merged
Mytherin merged 3 commits intoduckdb:v1.5-variegatafrom
Maxxen:bump-spatial-patch-ducklake
Feb 1, 2026
Merged

Add back spatial to V1.5, patch ducklake#20734
Mytherin merged 3 commits intoduckdb:v1.5-variegatafrom
Maxxen:bump-spatial-patch-ducklake

Conversation

@Maxxen
Copy link
Member

@Maxxen Maxxen commented Jan 29, 2026

A lot of the ducklake geo handling could probably be much simplified now, but I just need the tests to pass for now and will make another pass in the ducklake repo later.

@Maxxen Maxxen marked this pull request as ready for review January 29, 2026 20:29
@Maxxen Maxxen mentioned this pull request Jan 29, 2026
@Maxxen
Copy link
Member Author

Maxxen commented Jan 30, 2026

Test failures unrelated @Mytherin

@carlopi
Copy link
Contributor

carlopi commented Jan 30, 2026

@Maxxen: I am not sure failure is unrelated, or at least I have not seen this fail elsewhere.

I think it's fine to merge and look at this on a side, but my theory is that some global CURL setting are conflicting between curl bundled with spatial (via GDAL) and curl bundled with httpfs.
That needs a second look.


EDIT: the test looks like:

statement ok
SET ca_cert_file = 'README.md';

statement error
FROM read_blob('https://duckdb.org/')
----
<REGEX>:.*IO Error.*SSL.*

where here it seems that ca_cert_file is somehow ignored.

@Maxxen
Copy link
Member Author

Maxxen commented Jan 30, 2026

@carlopi I thought it was a transient http issue. can you reproduce it? It was green on my local fork CI https://github.com/Maxxen/duckdb/actions/runs/21484736374

@carlopi
Copy link
Contributor

carlopi commented Jan 30, 2026

Discussed in the office with @Maxxen, I think path forward is merging both this PR AND #20746 together.

Then there are all goodies of this PR, and restoring CI to fully green.

Issue mentioned with ca_cert_file to be investigated on a side.

@Mytherin
Copy link
Collaborator

#20746 targets main, so if this PR breaks CI then that will not fix it. Is that meant to also target v1.5?

@carlopi
Copy link
Contributor

carlopi commented Jan 30, 2026

#20746 targets main, so if this PR breaks CI then that will not fix it. Is that meant to also target v1.5?

Indeed, fixed up, but needs to go through CI.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 30, 2026 11:44
@Mytherin Mytherin marked this pull request as ready for review January 30, 2026 11:53
Mytherin added a commit that referenced this pull request Jan 30, 2026
…& CMake fixes (#20746)

Built on top of #20735, that adds
support for bulk deletes, with some extra commits that should unlock
#20734.

Merging both #20734 and this PR
should restore `spatial` and `ducklake` with a green CI.
@Maxxen Maxxen force-pushed the bump-spatial-patch-ducklake branch from 73a4205 to 019f120 Compare January 31, 2026 19:28
@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 31, 2026 19:28
@Maxxen Maxxen marked this pull request as ready for review January 31, 2026 19:29
@Mytherin Mytherin merged commit 16d2282 into duckdb:v1.5-variegata Feb 1, 2026
102 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Feb 1, 2026

Thanks!

krlmlr added a commit to krlmlr/duckdb-r that referenced this pull request Feb 28, 2026
Date: 2026-02-02 13:44:38 +0100

Integrate caching filesystem into json reader (duckdb/duckdb#20575)
[chore] Skip building spatial, needs a patch, needs to be reverted (duckdb/duckdb#20772)
Add back spatial to V1.5, patch ducklake (duckdb/duckdb#20734)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Feb 28, 2026
Date: 2026-02-02 13:44:38 +0100

Integrate caching filesystem into json reader (duckdb/duckdb#20575)
[chore] Skip building spatial, needs a patch, needs to be reverted (duckdb/duckdb#20772)
Add back spatial to V1.5, patch ducklake (duckdb/duckdb#20734)
krlmlr added a commit to krlmlr/duckdb-r that referenced this pull request Feb 28, 2026
Date: 2026-02-02 13:44:38 +0100

Integrate caching filesystem into json reader (duckdb/duckdb#20575)
[chore] Skip building spatial, needs a patch, needs to be reverted (duckdb/duckdb#20772)
Add back spatial to V1.5, patch ducklake (duckdb/duckdb#20734)
krlmlr added a commit to krlmlr/duckdb-r that referenced this pull request Feb 28, 2026
Date: 2026-02-02 13:44:38 +0100

Integrate caching filesystem into json reader (duckdb/duckdb#20575)
[chore] Skip building spatial, needs a patch, needs to be reverted (duckdb/duckdb#20772)
Add back spatial to V1.5, patch ducklake (duckdb/duckdb#20734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants