Add back UnregisterSubSystem and make ExtractSubSystem work with OpenerFileSystem#20694
Merged
Mytherin merged 4 commits intoduckdb:v1.5-variegatafrom Jan 28, 2026
Merged
Conversation
…ile system, instead only unregister it
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-01-28 08:45:13 +0100 Add back `UnregisterSubSystem` and make `ExtractSubSystem` work with `OpenerFileSystem` (duckdb/duckdb#20694) Rewrite many older concurrent tests to SQLLogicTests (duckdb/duckdb#20693)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-01-28 08:45:13 +0100 Add back `UnregisterSubSystem` and make `ExtractSubSystem` work with `OpenerFileSystem` (duckdb/duckdb#20694) Rewrite many older concurrent tests to SQLLogicTests (duckdb/duckdb#20693)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-01-28 08:45:13 +0100 Add back `UnregisterSubSystem` and make `ExtractSubSystem` work with `OpenerFileSystem` (duckdb/duckdb#20694) Rewrite many older concurrent tests to SQLLogicTests (duckdb/duckdb#20693)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Feb 28, 2026
Date: 2026-01-28 08:45:13 +0100 Add back `UnregisterSubSystem` and make `ExtractSubSystem` work with `OpenerFileSystem` (duckdb/duckdb#20694) Rewrite many older concurrent tests to SQLLogicTests (duckdb/duckdb#20693)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back the
UnregisterSubSystemmethod removed in #20547. This is made thread-safe by only unregistering, i.e. the file system is not actually deleted. The file system is kept around as we don't have any guarantees at this point about existing files still being open that use that file system. As such it only prevents new files from using the file system.CC @evertlammerts