Skip to content

feat(adbc): support ADBC_INFO_DRIVER_ADBC_VERSION (new in ADBC 1.1.0)#20344

Merged
pdet merged 2 commits intoduckdb:mainfrom
eitsupi:adbc-info-update
Dec 30, 2025
Merged

feat(adbc): support ADBC_INFO_DRIVER_ADBC_VERSION (new in ADBC 1.1.0)#20344
pdet merged 2 commits intoduckdb:mainfrom
eitsupi:adbc-info-update

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Dec 29, 2025 •
edited
Loading

Adds support for the ADBC 1.1.0 GetInfo code ADBC_INFO_DRIVER_ADBC_VERSION (info code 103) in the ADBC driver.

And, updates the GetInfo implementation to use the official ADBC_INFO_* constants instead of assuming the info codes are contiguous (0, 1, 2, …), aligning behavior with other drivers in the arrow-adbc repo.

For example, if we retrieve information using adbcdrivermanager::adbc_connection_get_info(conn) in R, we can see the following:

# A tibble: 6 × 2
  info_name info_value$string_value $bool_value $int64_value $int32_bitmask $string_list
      <dbl> <chr>                   <lgl>              <dbl>          <int>  <list<chr>>
1         0 duckdb                  NA                    NA             NA             
2         1 v1.5.0-dev5080          NA                    NA             NA             
3       100 ADBC DuckDB Driver      NA                    NA             NA             
4       101 v1.5.0-dev5080          NA                    NA             NA             
5       102 (unknown)               NA                    NA             NA             
6       103 NA                      NA               1001000             NA             
# ℹ 1 more variable: info_value$int32_to_int32_list_map <list<df[,2]>>

This format can be compared to the SQLite driver to confirm it matches (though the SQLite driver doesn't seem to include ADBC_INFO_DRIVER_ADBC_VERSION (103) by default; I've included all the information here as before, but I'm not sure which is ideal).

# A tibble: 5 × 2
  info_name info_value$string_value $bool_value $int64_value $int32_bitmask $string_list
      <dbl> <chr>                   <lgl>              <dbl>          <int>  <list<chr>>
1         0 SQLite                  NA                    NA             NA             
2         1 3.50.4                  NA                    NA             NA             
3       100 ADBC SQLite Driver      NA                    NA             NA             
4       101 (unknown)               NA                    NA             NA             
5       102 0.7.0                   NA                    NA             NA             
# ℹ 1 more variable: info_value$int32_to_int32_list_map <list<df[,2]>>

cc @lidavidm

@eitsupi eitsupi marked this pull request as draft December 29, 2025 17:08
@eitsupi eitsupi marked this pull request as ready for review December 29, 2025 17:17
@eitsupi eitsupi mentioned this pull request Dec 29, 2025
Open
@eitsupi eitsupi marked this pull request as draft December 30, 2025 02:06
@eitsupi eitsupi marked this pull request as ready for review December 30, 2025 02:30
@eitsupi eitsupi marked this pull request as draft December 30, 2025 03:31
@eitsupi eitsupi marked this pull request as ready for review December 30, 2025 05:19
@pdet
Copy link
Collaborator

pdet commented Dec 30, 2025

LGTM! Thanks!

@pdet pdet merged commit 6b2c9ed into duckdb:main Dec 30, 2025
58 checks passed
@eitsupi eitsupi deleted the adbc-info-update branch December 30, 2025 11:45
@evertlammerts evertlammerts mentioned this pull request Jan 5, 2026
Merged
evertlammerts added a commit to duckdb/duckdb-python that referenced this pull request Jan 5, 2026
@evertlammerts
Fix adbc tests (#248)
087dd1d 
Fixes ADBC tests to align with changes made in
duckdb/duckdb#20344
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Feb 26, 2026
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@e7e6734
b3fc405 
`GEOMETRY` Rework: Part 5 - Coordinate Reference System Support (duckdb/duckdb#20143)
feat(adbc): support `ADBC_INFO_DRIVER_ADBC_VERSION` (new in ADBC 1.1.0) (duckdb/duckdb#20344)
feat(adbc): support the uri option of ADBC 1.1.0 (duckdb/duckdb#20312)
@github-actions github-actions bot mentioned this pull request Feb 26, 2026
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Feb 26, 2026
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@e7e6734 (#2134)
17c25c5 
`GEOMETRY` Rework: Part 5 - Coordinate Reference System Support (duckdb/duckdb#20143)
feat(adbc): support `ADBC_INFO_DRIVER_ADBC_VERSION` (new in ADBC 1.1.0) (duckdb/duckdb#20344)
feat(adbc): support the uri option of ADBC 1.1.0 (duckdb/duckdb#20312)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lidavidm lidavidm lidavidm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eitsupi @pdet @lidavidm