Skip to content

[Chore] Tidy test configs#18426

Merged
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
taniabogatsch:tidy-configs
Jul 29, 2025
Merged

[Chore] Tidy test configs#18426
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
taniabogatsch:tidy-configs

Conversation

@taniabogatsch
Copy link
Contributor

While looking into https://github.com/duckdblabs/duckdb-internal/issues/5207, I noticed that the descriptions and test config files had already diverged a bit and decided to unify them.

@taniabogatsch
Copy link
Contributor Author

taniabogatsch commented Jul 28, 2025

I just now noticed that we use {TEST_DIR}/{BASE_TEST_NAME}/memory.db to 'pretend' our database is an in-memory database for tests that explicitly query duckdb_databases.

I'll try to update these tests and fix the storage runs.

@taniabogatsch taniabogatsch marked this pull request as draft July 28, 2025 13:26
@taniabogatsch taniabogatsch marked this pull request as ready for review July 28, 2025 15:39
@Mytherin Mytherin merged commit 2efc9ec into duckdb:v1.3-ossivalis Jul 29, 2025
36 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@taniabogatsch taniabogatsch deleted the tidy-configs branch July 29, 2025 07:21
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jul 30, 2025
[Fix] Reset segment memory when initialising new Prefix (duckdb/duckdb#18441)
[Chore] Tidy test configs (duckdb/duckdb#18426)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jul 30, 2025
[Fix] Reset segment memory when initialising new Prefix (duckdb/duckdb#18441)
[Chore] Tidy test configs (duckdb/duckdb#18426)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants