[chore] Fixup side-effects from 8cf9ed43b60#18385
Merged
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom Jul 24, 2025
Merged
[chore] Fixup side-effects from 8cf9ed43b60#18385Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom
Conversation
That commit was keeping same logic for Windows, but side-effectful on macos, that should fix it
Contributor
Author
|
Checked to be worked properly at https://github.com/carlopi/duckdb/actions/runs/16489665469/job/46623585724, deployed extensions/produced artifacts have all extensions in. |
Collaborator
|
Thanks |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 25, 2025
[BUGFIX] Update delim offset for RHS of DELIM JOIN when correlated column is in RHS of Cross product (duckdb/duckdb#18375) [chore] Fixup side-effects from 8cf9ed43b60 (duckdb/duckdb#18385)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 25, 2025
[BUGFIX] Update delim offset for RHS of DELIM JOIN when correlated column is in RHS of Cross product (duckdb/duckdb#18375) [chore] Fixup side-effects from 8cf9ed43b60 (duckdb/duckdb#18385) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That commit was keeping same logic for Windows, but side-effectful on macos/linux, that should fix it.
I have not yet double checked, on my fork CI, this actually behaves as intended.
Problem this solves: currently OSX CI is green, but for
amd64uploads all extensions while forarm64only core_functions.