Add VS2019 compat flag to Python wheel build#18198
Merged
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom Jul 10, 2025
Merged
Add VS2019 compat flag to Python wheel build#18198Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom
Conversation
This change adds `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` preprocessor definition to Python wheel builds on Windows. For details see duckdb#17991, where the same definition was added for CLI builds. Fixes: duckdb#17971
8ab26a8 to
34486bb
Compare
carlopi
approved these changes
Jul 10, 2025
Contributor
carlopi
left a comment
There was a problem hiding this comment.
LGTM! I think there is no real way to test properly in CI setup than merge, and then check manually on the first built 1.3.3-dev builds.
Thanks!
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 12, 2025
Allow explicit compression for user types (duckdb/duckdb#18219) Skip logging test for smaller block sizes (duckdb/duckdb#18201) Add VS2019 compat flag to Python wheel build (duckdb/duckdb#18198) Bump Julia to v1.3.2 (duckdb/duckdb#18185) Bump spatial again: include re-linking for handling global objects in Wasm (duckdb/duckdb#18170)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 12, 2025
Allow explicit compression for user types (duckdb/duckdb#18219) Skip logging test for smaller block sizes (duckdb/duckdb#18201) Add VS2019 compat flag to Python wheel build (duckdb/duckdb#18198) Bump Julia to v1.3.2 (duckdb/duckdb#18185) Bump spatial again: include re-linking for handling global objects in Wasm (duckdb/duckdb#18170) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTORpreprocessor definition to Python wheel builds on Windows.For details see #17991, where the same definition was added for CLI builds.
Fixes: #17971