Storge the argument and value of arg_min_max in the state as a unique_ptr#17749
Merged
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom Jun 4, 2025
Merged
Storge the argument and value of arg_min_max in the state as a unique_ptr#17749Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
Conversation
Mytherin
reviewed
Jun 2, 2025
Collaborator
Mytherin
left a comment
There was a problem hiding this comment.
Thanks for the PR! Aggregate states are pretty space-critical given they are instantiated per row in the aggregate hash table (which can be many). I'm not a big fan of expanding the aggregate state size here - can we fix this in a different way?
extension/core_functions/aggregate/distributive/arg_min_max.cpp
Outdated
Show resolved
Hide resolved
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
Storge the argument and value of arg_min_max in the state as a unique_ptr (duckdb/duckdb#17749)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2025
Storge the argument and value of arg_min_max in the state as a unique_ptr (duckdb/duckdb#17749) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also simplifies the destruction code, since these strings will be cleaned up with the
ArgMinMaxStateBase