initialize the read with the OpenFile info and not just the path#17652
Merged
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom May 27, 2025
Conversation
Collaborator
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 2, 2025
initialize the read with the OpenFile info and not just the path (duckdb/duckdb#17652)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/4961
Another part of the fix is to fix the HTTPFileCache, but that needs to be done in the httpfs extension.
This uses the OpenFileInfo
fileto create the new file handle. This way, we also copy all of the extended properties of the OpenFileInfo likevalidate_external_cacheandfile_size. This makes it easier to prevent unnecessary extra (1) head requests on large files. But if there are multiple files that are all a bit larger, this these HEAD requests add up