Merged
Conversation
Collaborator
Author
|
I don't think the failing test is related EDIT: the failing Windows test IS related, my |
Closed
Collaborator
|
Thanks! |
|
Dear Developers, do you think that this PR also fix #17335? |
Thanks for your effort! Do you think this issue #17335 is fixed? If you can review it, I will appreciate it! |
2 tasks
Collaborator
Author
|
@TheoristCoder I checked and the PR also fixed #17335 :) |
Thanks for your fixing! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 2, 2025
Bugfixes (duckdb/duckdb#17543) Issue duckdb/duckdb#17606: Disable TIMESTAMPTZ Casts (duckdb/duckdb#17614)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
hashjoin_highcardinalitybenchmark #17521 (benchmark file was wrong, we now throw a more useful error)delim_offsetwas wrong for left joins during subquery decorrelation)Also adds some type verification to the
ColumnBindingResolver.