Skip to content

Add uniq_ptr_cast for interpreted benchmark.#16151

Merged
Mytherin merged 1 commit intoduckdb:mainfrom
Tmonster:fix_benchmark_building
Feb 10, 2025
Merged

Add uniq_ptr_cast for interpreted benchmark.#16151
Mytherin merged 1 commit intoduckdb:mainfrom
Tmonster:fix_benchmark_building

Conversation

@Tmonster
Copy link
Contributor

Weekly Regression Runner couldn't build the Benchmark runner. Came down to a uniq_ptr_cast issue.

Failing workflow https://github.com/duckdblabs/duckdb-internal/actions/runs/13231781654

@Mytherin
Copy link
Collaborator

Thanks! This doesn't need the unique_ptr_cast, by the way, just a return std::move(result) will suffice. I suspect this wasn't tripped by other CI because we don't build the benchmark runner on all platforms.

@Mytherin Mytherin merged commit 6ec8573 into duckdb:main Feb 10, 2025
47 checks passed
Antonov548 added a commit to Antonov548/duckdb-r that referenced this pull request Feb 27, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161)
Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155)
Hopefully fixing ci runs (duckdb/duckdb#16150)
Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 5, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161)
Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155)
Hopefully fixing ci runs (duckdb/duckdb#16150)
Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161)
Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155)
Hopefully fixing ci runs (duckdb/duckdb#16150)
Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161)
Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155)
Hopefully fixing ci runs (duckdb/duckdb#16150)
Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161)
Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155)
Hopefully fixing ci runs (duckdb/duckdb#16150)
Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
Parquet Reader: Split `CreateReader` into two separate stages - `ParseSchema` and `CreateReader` (duckdb/duckdb#16161)
Removed the last CI job that used the Ubuntu 18 setup (duckdb/duckdb#16155)
Hopefully fixing ci runs (duckdb/duckdb#16150)
Add uniq_ptr_cast for interpreted benchmark. (duckdb/duckdb#16151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants