Disallow attaching non-DuckDB databases if enable_external_access is disabled#16015
Merged
Mytherin merged 2 commits intoduckdb:v1.2-histrionicusfrom Feb 1, 2025
Merged
Conversation
Contributor
|
I am not sure, I think it might not be the right place, since a sqlite file will still pass the check (say |
Collaborator
Author
|
That's a good point - but the SQLite file will only pass the check if it is able to be opened using the DuckDB filesystem which means it is in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts the changes made in #14568
We used to fully disallow
ATTACHwhen this setting was disabled. We now allow attaching, and fail later based on theallowed_directories/allowed_paths. This allows us to still attach files if they are within the allowed set of paths.Storage extensions do not necessarily abide by these rules, however. For now we just move back to disallowing
ATTACHof non-DuckDB files entirely if the setting is set to false.