Merged
Conversation
carlopi
reviewed
Nov 28, 2024
Contributor
carlopi
left a comment
There was a problem hiding this comment.
Two comments, but cool stuff.
carlopi
reviewed
Nov 28, 2024
.github/workflows/Regression.yml
Outdated
Comment on lines
+93
to
+94
| git clone https://github.com/duckdb/duckdb.git | ||
| git checkout $(gh run list --repo duckdb/duckdb --branch=main --workflow=Regression --status=success --json=headSha --limit=1 --jq '.[0].headSha') |
Contributor
There was a problem hiding this comment.
I am not sure of the syntax here, I think it should be:
git clone https://github.com/duckdb/duckdb.git
cd duckdb
git checkout $(gh run list --repo duckdb/duckdb --branch=main --workflow=Regression --status=success --json=headSha --limit=1 --jq '.[0].headSha')
cd ..
make
cd duckdb
make
cd ..
this is since you need to checkout the repo in the duckdb folder / keep the workflows as similar as possible (same direction of what's new and what's old)
carlopi
reviewed
Nov 28, 2024
.github/workflows/Regression.yml
Outdated
| run: | | ||
| make | ||
| git clone https://github.com/duckdb/duckdb.git | ||
| git checkout $(gh run list --repo duckdb/duckdb --branch=main --workflow=Regression --status=success --json=headSha --limit=1 --jq '.[0].headSha') |
Contributor
There was a problem hiding this comment.
Suggested change
| git checkout $(gh run list --repo duckdb/duckdb --branch=main --workflow=Regression --status=success --json=headSha --limit=1 --jq '.[0].headSha') | |
| cd duckdb && git checkout $(gh run list --repo duckdb/duckdb --branch=main --workflow=Regression --status=success --json=headSha --limit=1 --jq '.[0].headSha') && cd .. |
Me again 👋, I think checkout needs to be done IN the duckdb folder.
Contributor
There was a problem hiding this comment.
I think adding this suggestion + merging is cool to me
Collaborator
Author
There was a problem hiding this comment.
Sorry I was not paying attention well, I think it should be good now
carlopi
approved these changes
Nov 29, 2024
Collaborator
|
Thanks! |
Mytherin
added a commit
that referenced
this pull request
Dec 2, 2024
Since #14973, our nightly no longer runs regressions against itself (always succeeding) but against the last successful nightly regression, now sometimes failing. This has caught a [CSV regression](https://github.com/duckdb/duckdb/actions/runs/12110544726/job/33761104729#step:17:228). If we don't fix this regression, subsequent workflow runs will fail indefinitely. Sometimes, however, we want to accept regressions, for example, so the CSV reader can parse more timestamp types (at the cost of taking more time - at least, I think that's what's happening here). In such cases, we need to re-run the regression workflow against itself so that it succeeds. This PR adds an input parameter to run the regression test against a specific DuckDB version. This would also allow us to run the current main against v.1.13.
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Fix extension entries (duckdb/duckdb#15027) [PySpark] Add more functions such as slice, split, standard deviations, etc. (duckdb/duckdb#14863) More regression tests (duckdb/duckdb#14973)
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Fix extension entries (duckdb/duckdb#15027) [PySpark] Add more functions such as slice, split, standard deviations, etc. (duckdb/duckdb#14863) More regression tests (duckdb/duckdb#14973)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Fix extension entries (duckdb/duckdb#15027) [PySpark] Add more functions such as slice, split, standard deviations, etc. (duckdb/duckdb#14863) More regression tests (duckdb/duckdb#14973) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.