python: use PyUnicode_FromStringAndSize()#14895
Merged
Mytherin merged 1 commit intoduckdb:mainfrom Nov 19, 2024
methane:python-use-capi
Merged
python: use PyUnicode_FromStringAndSize()#14895Mytherin merged 1 commit intoduckdb:mainfrom methane:python-use-capi
Mytherin merged 1 commit intoduckdb:mainfrom
methane:python-use-capi
Conversation
Collaborator
|
Thanks! Playing around with this locally it seems to perform around as well as the current implementation, in which case definitely agreed we should switch back to the stable API. |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 24, 2024
Top-N: Improve performance with large heaps, and correctly call Reduce (duckdb/duckdb#14900) python: use PyUnicode_FromStringAndSize() (duckdb/duckdb#14895)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 24, 2024
Top-N: Improve performance with large heaps, and correctly call Reduce (duckdb/duckdb#14900) python: use PyUnicode_FromStringAndSize() (duckdb/duckdb#14895) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuckDB introduced optimization for UTF-8 decoder.
It is up to 40% faster for short non-ASCII case.
But it is 4x slower for long ASCII case.
Python has optimized code to decode ASCII. So decoding UTF-8 containing long ASCII part is faster than UTF8Proc::UTF8ToCodepoint.
And I am optimizing short non-ASCII case handling in CPython.
ref: python/cpython#126025 (comment)
Background