Optimistic writes: flush the last row group in all scenarios#14759
Merged
Mytherin merged 2 commits intoduckdb:mainfrom Nov 8, 2024
Merged
Optimistic writes: flush the last row group in all scenarios#14759Mytherin merged 2 commits intoduckdb:mainfrom
Mytherin merged 2 commits intoduckdb:mainfrom
Conversation
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 21, 2024
Optimistic writes: flush the last row group in all scenarios (duckdb/duckdb#14759)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 21, 2024
Optimistic writes: flush the last row group in all scenarios (duckdb/duckdb#14759) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When optimistically writing data to disk - there were a few scenarios in which we would not optimistically write row groups:
CollectionMergerwould have a collection with a singleColumnDataCollectionin itCombineFor regular insertions, this would not have a large impact as most data would still be written optimistically - but for the optimistic WAL write added in #13372 we need all row groups written in sequence to be optimistically written out. By not flushing all row groups, large WAL files would still be created.