JDBC getColumns does not get all available data types#1380
Merged
hannes merged 2 commits intoduckdb:masterfrom Feb 12, 2021
Merged
JDBC getColumns does not get all available data types#1380hannes merged 2 commits intoduckdb:masterfrom
hannes merged 2 commits intoduckdb:masterfrom
Conversation
Member
|
Good catch! Could you also have a look at the JDBC tests and see that they pass please? |
Author
|
The JDBC tests were not completing successfully because the getColumn test was expecting only one record for the queried columns, but there are two. |
Member
|
Looks great, thanks. |
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
Feb 17, 2024
Trap integer overflows onverting weeks to days.
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
Feb 17, 2024
Formatting.
Mytherin
added a commit
that referenced
this pull request
Feb 19, 2024
Fuzzer #1380: To Weeks Overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling getMetaData().getColumns to get the columns of a table from the information schema, only the first column gets returned.
Example snippet
It turns out that the issue is due to the fact that to optimize the retrieval, the information schema is first queried with all the possible column types, but that Resultset is not cycled through: only the first record is used.
Adding a while cycle fixes the problem.