Merged
Conversation
Member
|
This looks really good! I have three minor comments:
|
Collaborator
Author
|
The reason I only went for double only in the product was to diminish the overflow problem, if adding all types this would need to be checked and handled for each multiplication I think. |
Mytherin
reviewed
Feb 8, 2021
Collaborator
Mytherin
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is the bees knees. Some comments, mostly suggestions for extra tests:
Mytherin
reviewed
Feb 9, 2021
test/sql/aggregate/aggregates/test_approximate_distinct_count.test
Outdated
Show resolved
Hide resolved
Mytherin
reviewed
Feb 10, 2021
| //! FIXME: Hash this in the future | ||
| auto size = value.size() > 8 ? 8 : value.size(); | ||
| state->log->Add((uint8_t *)&value, size); | ||
| auto str_hash = std::hash<std::string> {}(input[idx].GetString()); |
Collaborator
There was a problem hiding this comment.
Can you use our own hash instead of std::hash? This is not very efficient as it constructs a std::string object which involves memory allocation and copying the string.
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
Feb 17, 2024
Give up fast on window binding ORDER BY failures
Mytherin
added a commit
that referenced
this pull request
Feb 19, 2024
Fuzzer #1372: Order Bind Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the following aggr functions:
The only function missing from #1125 is the any (alias for first) because the Postgres parser reserves it to be used with subqueries. Not sure how (or even if I should dare to) change the parser.