initializes unknown indexes on catalog lookup#11551
Merged
Mytherin merged 2 commits intoduckdb:mainfrom Apr 11, 2024
Merged
Conversation
Collaborator
|
Thanks! LGTM |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 11, 2024
Merge pull request duckdb/duckdb#11551 from Maxxen/initialize-unknown-index-on-lookup Merge pull request duckdb/duckdb#11600 from chrisiou/support-gzipped-files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over in https://github.com/Maxxen/duckdb-vss I've ran into an issue where if you create a custom index and restart the database, its not possible to
DROPthe index or the table it applies to without first running a query against the table. This is because we don't initialize "unknown" extension-provided indexes until we need to access them during a scan.This PR changes this so that any unknown indexes are initialized as soon as you make a catalog lookup on a table or an index entry directly. Im not sure if this is the best place to do this, but as we're initializing foreign keys here anyway it felt suitable.