Use subdirectory within target/tests/#219
Merged
Merged
Conversation
Or to put it another way, do not assume that the project's target/tests/target/ is ours to use as we wish. Empirically, this is sufficient on its own to resolve eupn/macrotest#83 dtolnay#218 (I don't know precisely what the difference is between trybuild's and mcarotest's build invocations. It is possible that it would be better for cargo to be able to cache both in the target directory, but I think we should use a namespaced directory, regardless.)
bors Bot
added a commit
to taiki-e/cargo-llvm-cov
that referenced
this pull request
Jan 15, 2023
238: Address target directory change in trybuild 1.0.76 r=taiki-e a=taiki-e See dtolnay/trybuild#219 Co-authored-by: Taiki Endo <te316e89@gmail.com>
djc
pushed a commit
to askama-rs/askama-old
that referenced
this pull request
Jan 24, 2023
In <dtolnay/trybuild#219> the output of error messages was subtly changed, because they introduced a subdirectoy in their temp path. This PR fixes the mismatch between the expected and the actual output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or to put it another way, do not assume that the project's
target/tests/target/is ours to use as we wish.Empirically, this is sufficient on its own to resolve
eupn/macrotest#83
#218
(I don't know precisely what the difference is between trybuild's and mcarotest's build invocations. It is possible that it would be better for cargo to be able to cache both in the target directory, but I think we should use a namespaced directory, regardless.)
I will be submitting a similar merge request for macrotest, which, likewise, is sufficient on its own to resolve the problem I was experiencing. I think these changes should be made to both packages.