Skip to content

Avoid calling a nonstandard write! macro that might be in scope#240

Merged
dtolnay merged 1 commit intomasterfrom
stdwrite
Jul 6, 2023
Merged

Avoid calling a nonstandard write! macro that might be in scope#240
dtolnay merged 1 commit intomasterfrom
stdwrite

Conversation

@dtolnay
Copy link
Owner

@dtolnay dtolnay commented Jul 6, 2023

Fixes #239.

@dtolnay dtolnay merged commit 6165f58 into master Jul 6, 2023
@dtolnay dtolnay deleted the stdwrite branch July 6, 2023 22:11
@poliorcetics
Copy link

poliorcetics commented Jul 10, 2023

Strangely enough we were relying on this exact behaviour (being able to override the write! macro used). (cue relevant XKCD)

Would you be okay with me making a PR to add a feature for it ? I can understand it's such a niche use-case you may not want to

takumi-earth pushed a commit to earthlings-dev/thiserror that referenced this pull request Jan 27, 2026
Avoid calling a nonstandard write! macro that might be in scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Macro derive fails when a non-std write macro is in scope

2 participants