Don't track bridge files in OUT_DIR#1668
Merged
dtolnay merged 1 commit intodtolnay:masterfrom Nov 11, 2025
Merged
Conversation
Files in the `OUT_DIR` are likely generated by the very same build script. As such, they likely have a modification time that is after the build script's start time. This causes cargo to assume that the file has changed since the last run, thereby considering the build script dirty on every build. The result is that the build script and everything above in the dependency is recompiled on every build. This commit avoids that problem by emitting the `rerun-if-changed` command only for files that are not in the `OUT_DIR`.
Contributor
Author
|
Thanks for creating a new release! |
phil-opp
added a commit
to dora-rs/dora
that referenced
this pull request
Nov 12, 2025
This was referenced Nov 12, 2025
phil-opp
added a commit
to dora-rs/dora
that referenced
this pull request
Nov 12, 2025
- Update `cxx` crate to 1.0.188 to include dtolnay/cxx#1668 - Remove `rerun-if-changed` for autogenerated file (which always caused rebuild) - Rerun build script if the `DORA_NODE_API_CXX_INSTALL` env variable changes Discovered in #1182 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files in the
OUT_DIRare likely generated by the very same build script. As such, they likely have a modification time that is after the build script's start time. This causes cargo to assume that the file has changed since the last run, thereby considering the build script dirty on every build. The result is that the build script and everything above in the dependency is recompiled on every build.This commit avoids that problem by emitting the
rerun-if-changedcommand only for files that are not in theOUT_DIR.Proposed in #1462 (comment)