Skip to content

Preliminary platform-specific flavour support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dstufft merged 14 commits into from
Jan 4, 2015
Merged

Preliminary platform-specific flavour support #2

dstufft merged 14 commits into from
Jan 4, 2015

Conversation

@ionelmc
Copy link

@ionelmc ionelmc commented Dec 29, 2014

It's primitive now but there could be specialized flavours for: pypy, jython, ironpython (with os variants?)

@ionelmc ionelmc force-pushed the rewrite-windows-fixes branch from 3bc330c to b009ca7 Compare December 29, 2014 07:02
@ionelmc
Copy link
Author

ionelmc commented Dec 29, 2014

@dstufft So I finally got it to work on Windows ...

Tested this with Python 2.7.9:

C:\Users\ionel_000\Projects\virtualenv>rmdir /S /Q .ve & python -mvirtualenv .ve
Ignoring indexes: https://pypi.python.org/simple
Collecting pip
Collecting setuptools
Installing collected packages: setuptools, pip


Successfully installed pip-6.0.3 setuptools-8.3

C:\Users\ionel_000\Projects\virtualenv>.ve\Scripts\python -c "import sys, pprint; pprint.pprint(sys.path)"
['',
 'C:\\Windows\\SYSTEM32\\python27.zip',
 u'c:\\Python27\\DLLs',
 u'c:\\Python27\\lib',
 u'c:\\Python27\\lib\\plat-win',
 u'c:\\Python27\\lib\\lib-tk',
 u'c:\\Python27\\Scripts',
 u'C:\\Users\\ionel_000\\Projects\\virtualenv\\.ve',
 u'C:\\Users\\ionel_000\\Projects\\virtualenv\\.ve\\lib\\site-packages']

C:\Users\ionel_000\Projects\virtualenv>.ve\Scripts\pip install requests
Collecting requests
  Using cached requests-2.5.1-py2.py3-none-any.whl
Installing collected packages: requests

Successfully installed requests-2.5.1

C:\Users\ionel_000\Projects\virtualenv>.ve\Scripts\python -c "import requests; print requests.get('http://google.com')"
<Response [200]>

@ionelmc ionelmc mentioned this pull request Dec 29, 2014
Closed
23 tasks
@ionelmc
Copy link
Author

ionelmc commented Jan 4, 2015

@dstufft About the move of destination from create to __init__, initially I wanted to have the whole flavouring as specialised subclasses of the builders, but I've moved to a composition patter (the favour being passed to __init__), and I left the change with the destination. There's no huge advantage of having to pass destination everywhere, assuming a builder instance is not reused.

How would you have it?

@dstufft
Copy link
Owner

dstufft commented Jan 4, 2015

So the reason I had destination passed in was so that people could use the builders programmatically and reuse the builders for different virtual environments.

dstufft added a commit that referenced this pull request Jan 4, 2015
@dstufft
Merge pull request #2 from ionelmc/rewrite-windows-fixes
5ef371e 
Preliminary platform-specific flavour support
@dstufft dstufft merged commit 5ef371e into dstufft:rewrite Jan 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ionelmc @dstufft