Skip to content

fix: throw descriptive error when inserting variable statement with no declarations#1598

Merged
dsherret merged 1 commit into
latestfrom
fix_error_no_declarations_variable_stmt
Dec 30, 2024
Merged

fix: throw descriptive error when inserting variable statement with no declarations#1598
dsherret merged 1 commit into
latestfrom
fix_error_no_declarations_variable_stmt

Conversation

@dsherret

@dsherret dsherret commented Dec 30, 2024

Copy link
Copy Markdown
Owner

Too lazy to add a test for this edge case.

Closes #1584

@dsherret dsherret merged commit f4ed887 into latest Dec 30, 2024
@dsherret dsherret deleted the fix_error_no_declarations_variable_stmt branch December 30, 2024 16:34
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Jan 26, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Jan 28, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Feb 1, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Feb 2, 2025
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Feb 5, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
renovate Bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
##### [v25.0.1](https://github.com/dsherret/ts-morph/releases/tag/25.0.1)

##### Bug Fixes

-   bump TypeScript from 5.7.2 to 5.7.3 ([#1608](dsherret/ts-morph#1608)) ([a7397a0](dsherret/ts-morph@a7397a0))
-   update browser field to include fs/promises ([#1606](dsherret/ts-morph#1606)) ([ef81097](dsherret/ts-morph@ef81097))
##### [v25.0.0](https://github.com/dsherret/ts-morph/releases/tag/25.0.0)

#### What's Changed

-   feat: TypeScript 5.7.2 dsherret/ts-morph#1594
-   fix: switch back to fast-glob for stability dsherret/ts-morph#1595
-   fix: properly insert async keyword in arrow function dsherret/ts-morph#1597
-   fix: throw descriptive error when inserting variable statement with no declarations dsherret/ts-morph#1598
-   fix: removing last named import/export should not remove or change declaration dsherret/ts-morph#1599

**Full Changelog**: dsherret/ts-morph@24.0.0...25.0.0
##### [v24.0.0](https://github.com/dsherret/ts-morph/releases/tag/24.0.0)

#### What's Changed

-   perf: remove mkdirp dependency by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1549
-   perf: switch to tinyglobby to drop 15 dependencies by [@benmccann](https://github.com/benmccann) in dsherret/ts-morph#1558
-   fix: getDerivedClasses() isn't correct in some cases by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1557
-   fix: getBodyText() doesn't work as would be expected by [@jmyrick02](https://github.com/jmyrick02) in dsherret/ts-morph#1560
-   feat: TypeScript 5.6 by [@dsherret](https://github.com/dsherret) in dsherret/ts-morph#1576

#### New Contributors

-   [@benmccann](https://github.com/benmccann) made their first contribution in dsherret/ts-morph#1549
-   [@jmyrick02](https://github.com/jmyrick02) made their first contribution in dsherret/ts-morph#1557

**Full Changelog**: dsherret/ts-morph@23.0.0...24.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected! Inserting syntax kind of VariableStatement, but ExpressionStatement was inserted.

1 participant