Merged
Conversation
We got some highlight errors when `pygments` tried to parse the code So, we need to use the directive `:force:` and force our code to be highlighted
doc8 is falling because it can't figure out what's the `:force:` directive
Member
|
😭 |
sobolevn
reviewed
Sep 18, 2020
Member
sobolevn
left a comment
There was a problem hiding this comment.
Thanks a lot for your work!
I don't know how to fix Hypothesis types right now.
Because the easiest way is to contribute to Hypothesis the fix we need.
But, the fix we need is non-trivial. Because it should work for all generics, not just Type, etc.
And I don't have any solution to offer right now.
So, if you have any ideas how to solve the type resolutions, please, share them! 👍
sobolevn
reviewed
Sep 18, 2020
245b28f to
090436b
Compare
We need to add this import for now because `sphinx` can't figure out how to make the forward reference. To avoid warnings about this problem we have to import in all files that uses forward references.
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 74 74
Lines 1733 1771 +38
Branches 123 123
=========================================
+ Hits 1733 1771 +38
Continue to review full report at Codecov.
|
sobolevn
approved these changes
Sep 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed all documentation warnings and created
.readthedocs.ymlto active thefail_on_warningflag!!But we have a problem here, to fix the warnings about
ForwardReferenceI've added the importsfrom __future__ import annotations, unfortunately the hypothesis' tests are failing. I think it's related to this issue: HypothesisWorks/hypothesis#2565Checklist
Related issues
Closes #568