fix: gate built-in plugins until enabled state loads + fix IPC listener cleanup#239
Conversation
…er cleanup
P1: builtInEnabledMap started as {} so disabled built-in plugins
briefly activated on every launch. Now starts as null and built-in
plugins are excluded from PluginHost until listState() resolves.
P2: ipc.on() cleanup used removeAllListeners(channel) which nuked
other listeners on the same channel (pluginRuntimeStore). Changed
to removeListener with the specific handler reference.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 5 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Summary - **fix(mcp-server):** non-destructive FTS5 check + switch search to FTS5 MATCH (#241) - **fix:** unwrap getToken IPC result + use exact range for auto-link paste (#240) - **fix:** gate built-in plugins until enabled state loads + fix IPC listener cleanup (#239) - **feat:** allow disabling built-in plugins + fix MCP server FTS5 crash (#237) - **chore(deps):** sync postcss bump from main ## Test plan - [ ] CI passes (typecheck, lint, tests, build) - [ ] After merge, run Release workflow via `workflow_dispatch` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Summary
This commit was pushed to #237 after the squash-merge, so it didn't make it into develop. Cherry-picked here.
builtInEnabledMapstarted as{}so!== falsepassed for every plugin, briefly activating disabled plugins on launch. Now starts asnulland built-in plugins are excluded fromPluginHostuntillistState()resolvesipc.on()cleanup usedremoveAllListeners(channel)which nuked other listeners on the same channel (e.g.pluginRuntimeStore). Changed toremoveListenerwith the specific handler referenceTest plan
pnpm typecheck— cleanpnpm test— all pass🤖 Generated with Claude Code