fix: exclude @readied/* from ASAR to fix startup crash#233
Conversation
electron-builder auto-includes workspace packages in node_modules inside the ASAR even though electron-vite already bundles them. The CJS require in Electron finds the unbundled node_modules copy first, which fails with ERR_PACKAGE_PATH_NOT_EXPORTED because the workspace packages point to .ts source files in their exports map. Fix: add !node_modules/@readied/** to electron-builder files config so only the bundled code in out/ is used at runtime. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Release PR Merges `develop` into `main` to trigger a new release via semantic-release. ### Highlights since last release - **feat: allow disabling built-in plugins** + MCP server FTS5 fix (#237) - **fix: move @readied/* to devDependencies** — ASAR startup crash (#235) - **fix: exclude @readied/* from ASAR** (#233) - **feat: local HTTP API, quick capture, mermaid/math plugins** (#231) - **fix: replace removed lucide brand icons** (#229) - Multiple CI, type compat, and dependency fixes ### MCP server: sql.js → better-sqlite3 - FTS5 triggers now work (was crashing with `no such module: fts5`) - WAL mode for safe concurrent access with the desktop app - Runtime FTS5 check at startup with descriptive error ### Plugin system fixes (from code review) - Built-in plugins no longer briefly activate before enabled state loads - IPC listener cleanup no longer nukes unrelated listeners 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **New Features** * Built-in plugins can now be toggled on/off in settings; enabled/disabled states persist across sessions * Improved markdown editor URL auto-linking for more reliable link creation * **Bug Fixes** * Fixed URL auto-linking to correctly identify URLs when document content changes * **Tests** * Added comprehensive test suite for database trigger functionality * **Chores** * Migrated database backend for improved performance and stability <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixes ERR_PACKAGE_PATH_NOT_EXPORTED crash. Workspace packages already bundled by electron-vite.