fix: use npx wrangler for Cloudflare Pages deploy#138
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Notebooks now sync before notes in syncNow() to ensure note-notebook dependencies are satisfied. Adds pullNotebooks/pushNotebooks methods and applyRemoteNotebookChange for bidirectional notebook sync. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move validateNotebookTree from inline test definition to a shared module so it can be reused by the API route and other consumers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add conflict state to SyncStatusIndicator with amber warning icon and count. Conflicts now take priority over idle state so users discover them without navigating to Settings. Also export ConflictResolver from sync components barrel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DatabaseConnection.transaction() already calls the inner fn — no need for extra () at call site. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix pullNotebooks() to only advance cursor to last successfully applied change (prevents skipping failed changes on retry) - Fix tree validation snapshot to properly exclude deleted notebooks (prevents ghost parent references in validation) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat: add bidirectional notebook sync
test: add sync-core unit tests (62 tests)
feat: surface sync conflicts in status indicator
# Conflicts: # apps/desktop/src/main/services/apiClient.ts # apps/desktop/src/main/services/syncService.ts # packages/api/src/db/schema.ts # packages/api/src/routes/sync.ts # packages/storage-sqlite/src/migrations/index.ts
feat: add bidirectional tag sync
Configure automated code review with path-specific instructions for core, storage, desktop, and API packages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ration Add optional metadata (name, version, priority) to registerRemarkPlugin and registerRehypePlugin signatures for debugging and execution ordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # packages/storage-sqlite/src/repositories/SQLiteNoteRepository.ts
feat: add DataAPI — rich read-only data access for plugins
# Conflicts: # apps/desktop/src/renderer/pages/settings/sections/Section.module.css # packages/storage-sqlite/src/repositories/SQLiteNoteRepository.ts
feat: device management UI and API
# Conflicts: # packages/storage-sqlite/src/repositories/SQLiteNoteRepository.ts
test(api): add comprehensive sync API and encryption tests
…ning # Conflicts: # apps/desktop/src/renderer/App.tsx # apps/desktop/src/renderer/pages/settings/sections/Section.module.css
feat: sync hardening — auto-resume, history logging, bandwidth metrics
- Fix useThemeOverrides getSnapshot causing unnecessary re-renders - Fix theme restoration race condition with plugin loading - Add range.step validation in config validation - Record timing for failed plugin loads and init.js - Emit onNotesChanged events for note update/rename paths - Fix concurrent modification safety in DataAPI event dispatch - Fix DataAccessError import (value vs type-only) - Add range step validation tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Install Husky + lint-staged for pre-commit formatting - Add auto-merge workflow for owner PRs that pass CI - Auto-merge dependabot PRs after CI passes - External contributors' PRs still require owner review (CODEOWNERS) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace peter-evans action with gh CLI which doesn't need pull-request-number input and works directly with PR events. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Husky hooks: - commit-msg: validate conventional commits with commitlint - pre-push: run tests + typecheck before pushing CI improvements (Tier 1 - Speed): - Shared setup job with cached node_modules - Cancel in-progress runs on new pushes - Turborepo-ready with env vars CI improvements (Tier 2 - Quality): - Test coverage collection and artifact upload - Bundle size tracking reported in PR summary - PR size labels (XS/S/M/L/XL) - Auto-label PRs by changed packages CI improvements (Tier 3 - Security): - npm audit check for high severity vulnerabilities - License compatibility check (blocks GPL-3.0/AGPL/SSPL) - CodeQL static analysis (weekly + on PR) - Commitlint on PR titles Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
plugin-api is browser code without @types/node, so process.env causes typecheck failures. The debug log is low-cost and harmless in production. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: resolve CodeRabbit review issues across merged PRs
chore: add Husky pre-commit hooks and auto-merge workflow
## Summary - **Replaces** `apps/docs-site/` (VitePress/Vue) and `apps/marketing-site/` (Astro) with a single `apps/web/` Next.js 15 app - **Docs** served via Fumadocs at `/docs/*` (21 pages migrated from VitePress) - **Marketing** pages at `/` with navbar, footer, landing page, and 13 converted pages (pricing, FAQ, changelog, download, etc.) - **Stack unification**: entire frontend is now React + Next.js + Tailwind CSS 4 ## What changed - `apps/web/` — New unified Next.js + Fumadocs app (37 static pages) - `apps/docs-site/` — Deleted (replaced by `apps/web/content/docs/`) - `apps/marketing-site/` — Deleted (replaced by `apps/web/app/(marketing)/`) - `.github/workflows/docs.yml` — Updated for Next.js build - `.github/labeler.yml` — Updated labels for new structure - `turbo.json` — Updated build outputs ## Test plan - [x] `pnpm test` — all tests pass - [x] `next build` — 37 pages generated successfully - [ ] Manual review of docs pages at `/docs` - [ ] Manual review of marketing pages at `/` - [ ] Verify navbar, footer, mobile navigation work correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
## Summary - **Auto-disable crashing plugins**: PluginRegistry now auto-disables plugins after 3 consecutive crashes, with `resetErrors()` for manual re-enable and `isAutoDisabled()` query - **Plugin CLI commands**: Added `list`, `install`, `uninstall`, and `link` commands to `readied-plugin` CLI for managing community plugins from the terminal - **Cross-platform utils**: Shared `getPluginsDir()` resolves macOS/Win/Linux plugin directories ## Test Plan - [x] All 235+ tests pass (`pnpm test`) - [x] Auto-disable tests: threshold enforcement, reset behavior, pre-threshold behavior - [ ] Manual: `readied-plugin list` shows installed plugins - [ ] Manual: `readied-plugin link .` creates symlink for dev plugins 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added crash threshold protection that automatically disables plugins after repeated failures * Introduced plugin error state reset capability for recovery * Added CLI commands for plugin management: `list` (view installed plugins), `install` (add from archive or directory), `uninstall` (remove safely with confirmation), and `link` (for local development) <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
## Summary - Fix `wrangler-action@v3` failing with `ERR_PNPM_ADDING_TO_ROOT` in pnpm workspaces - Add `packageManager: pnpm` and `workingDirectory: apps/web` to the deploy step ## Context The Deploy Web workflow has been failing on every push to main because wrangler-action tries `pnpm add wrangler` at the workspace root without `-w`. ## Test plan - [ ] Merge to develop, then main, verify deploy workflow passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated deployment automation configuration to enhance build and release processes with improved package manager specification and working directory handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
## Summary - Add step to create `readied-web` project on Cloudflare Pages before deploying - Uses `continue-on-error: true` so it doesn't fail when project already exists - Add `--commit-dirty=true` to suppress wrangler git warning ## Context The Deploy Web workflow has never succeeded — project `readied-web` doesn't exist on Cloudflare Pages (error code 8000007). ## Test plan - [ ] Merge to develop → main, verify deploy succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
wrangler-action@v3 cannot install wrangler in pnpm workspaces (ERR_PNPM_ADDING_TO_ROOT). Using npx wrangler@3 directly bypasses this issue entirely. Also creates the Pages project if it doesn't exist. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughRemoves the separate Cloudflare Pages project existence check step and consolidates deployment logic into a single step using inline wrangler CLI commands. Replaces wrangler-action with direct Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mirror of #138 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # .github/workflows/docs.yml
Summary
cloudflare/wrangler-action@v3with directnpx wrangler@3callsERR_PNPM_ADDING_TO_ROOTthat prevented all deploys in pnpm workspacesContext
wrangler-actiontriespnpm add wranglerwhich fails in pnpm monorepos. Usingnpxbypasses this entirely.🤖 Generated with Claude Code
Summary by CodeRabbit