feat: allow bindgen-cli --split-linked-modules #1092#1443
Merged
drager merged 1 commit intodrager:masterfrom Nov 2, 2024
codeart1st:split-linked-modules
Merged
feat: allow bindgen-cli --split-linked-modules #1092#1443drager merged 1 commit intodrager:masterfrom codeart1st:split-linked-modules
drager merged 1 commit intodrager:masterfrom
codeart1st:split-linked-modules
Conversation
Contributor
Author
Twey
added a commit
to linera-io/linera-protocol
that referenced
this pull request
May 29, 2025
## Motivation When we merged `linera-web` into this repository, I left some relative paths in `build.bash` that break the build script. It would be nice to migrate back to `wasm-pack`, a more standard tool in the Rust world, but so far `wasm-pack` hasn't made a release that contains the necessary PR drager/wasm-pack#1443. ## Proposal Instead of using relative paths, extract the necessary paths from `cargo metadata`. ## Test Plan Tested locally. (We should really run `pnpm build` as part of the CI job, not just `cargo build`.) ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨